Merged
Conversation
The following fields are adding in google/protobuf/descriptor.proto: - FileDescriptorProto.option_dependency - DescriptorProto.visibility - EnumDescriptorProto.visibility They are unused in descriptor.proto itself, so it's only necessary to initialize the fields to their default value (supporting presence where needed).
Adding assertions that the new fields are unset.
This adds defaultSymbolVisibility to featureDefaults. It's unused at this point.
smaye81
approved these changes
Jul 1, 2025
|
@timostamm Thanks for the fix. Can you release a new version of |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 31.0 and 31.1 do not add any new features to Protobuf. All upcoming changes for Edition 2024 are still experimental, and are not supported by Protobuf-ES yet. But the releases include changes to google/protobuf/descriptor.proto and to google/protobuf/java_features.proto. With this PR, we're updating the pre-compiled types for these files.